Remove option to immediately commit pref changes on import#6531
Merged
TobiGr merged 3 commits intoTeamNewPipe:devfrom Jul 14, 2021
Merged
Remove option to immediately commit pref changes on import#6531TobiGr merged 3 commits intoTeamNewPipe:devfrom
TobiGr merged 3 commits intoTeamNewPipe:devfrom
Conversation
System is now not restarted with `System.exit(0)`. Instead it is done properly by finishing the activity and restarting the activity. This allows preference changes which are queued up asynchronously through `apply` to be applied.
Instead pass the value through the methods as parameter
XiangRongLin
added
the
codequality
Stypox
reviewed
Jul 4, 2021
Member
There was a problem hiding this comment.
For some reasons when the app is restarted I get the "The language will change once the app is restarted." toast, even though the language is correctly changed and updated throughout the app (I tried setting to a random language and then importing a database with "Use system language" language). Other than that I tested and it works well ;-)
Collaborator
|
@Stypox I see the same thing on the 0.21.6 RC and all the current debug APKs, so it can't be due to this PR. See #3312 (comment). |
Stypox
approved these changes
Jul 6, 2021
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
You are right @opusforlife2. Then I'm approving this :-)
opusforlife2
changed the title
XiangRongLin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Follow up to #6495. See commit messages for detailed descriptions
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
I tested it manually on API 28 emulator
Due diligence